feat: Add an async client and move the sync client#47
Merged
CosmicHorrorDev merged 2 commits intofrostly:masterfrom Jan 19, 2025
Merged
feat: Add an async client and move the sync client#47CosmicHorrorDev merged 2 commits intofrostly:masterfrom
CosmicHorrorDev merged 2 commits intofrostly:masterfrom
Conversation
This was referenced Jan 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better mirrors how
reqwestis structured this moves the synchronous client behind ablockingfeature and makes the default client async. In the future it could be good to make a common builder for the sync and async clients to avoid duplicating a lot of the code and docs